Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix responsive view on vulnerability dashboard #6246

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Fix responsive view on vulnerability dashboard #6246

merged 3 commits into from
Dec 21, 2023

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Dec 21, 2023 •
edited by asteriscos
Loading

Description

Starting at breakpoint 767px, there is an overlap of the vulnerability dashboard panels.
The solution found to avoid overlapping panels is to add styles starting from the breakpoint where the overlap occurred (767px).

Issues Resolved

Evidence

image

Test

Before remember to create the mapping of port 9200:9200 in osd1 in the dev.yml

  • Create the index (wazuh-states-vulnerabilities) in the manager and insert data and mapping (using comment).
  • Navigate to Threat Hunting -> Vulnerability Detection and Reduce window to less than 768px.
  • The panels must be arranged one below the order..

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Dec 21, 2023
@jbiset jbiset requested a review from a team as a code owner December 21, 2023 14:07
@jbiset jbiset linked an issue Dec 21, 2023 that may be closed by this pull request
Fix responsive view on vulnerability dashboard #6245
Closed
asteriscos
asteriscos approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Peek 2023-12-21 15-13

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.08% ( 4160 / 34437 )
Branches 8.18% ( 1893 / 23129 )
Functions 11.54% ( 944 / 8179 )
Lines 12.25% ( 4047 / 33028 )

yenienserrano
yenienserrano approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

@asteriscos asteriscos merged commit d6d6796 into 4.8.0 Dec 21, 2023
4 checks passed
@asteriscos asteriscos deleted the 6245-fix-responsive-view-on-vulnerability-dashboard branch December 21, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@jbiset jbiset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix responsive view on vulnerability dashboard
3 participants
@jbiset @asteriscos @yenienserrano