-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow edit groups from an agent #6250
Allow edit groups from an agent #6250
Conversation
3fe44c6
to
cb98c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🟢 (See comments)
Test
Actions menú 🟢
Actions menú when never connected 🟢
Edit groups modal 🟢
Actions menú with read only user 🟢
Deploy new agent button with read only user 🟢
Verify that actions work consistently with agent state and user permissions 🟢
Test buttons that have permission validations 🟢
Test table filters 🟢
Test table add/remove columns 🟡
Cannot change visibility of actions
column
Issue_actions.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test 🟢 (See 🟡 comments)
Test
Actions menú 🟢
Actions menú when never connected 🟡
Note
I'm not sure if it makes any sense to allow to see the Agent Details and then show the "Agent never connected" message. Even more when there's no quick way to go back.
Edit groups modal 🟢
Actions menú with read-only user 🟢
Deploy new agent button with read-only user 🟢
Verify that actions work consistently with agent state and user permissions 🟢
Test buttons that have permission validations 🟢
Test table filters 🟢
|
|
|
Description
In order to allow users to edit the groups from an agent, we have to introduce the following changes:
Edit groups
.WzElementPermissions
to manage permission when we need a component different to a button.AgentsTable
class component to a functional component because we need to use an existing hook to disable theEdit groups
action button.Issues Resolved
#6138
Evidence
Actions menú
Actions menú when never connected
Edit groups
modalActions menú with read only user
Deploy new agent
button with readonly userTest
To create a readonly user: https://documentation.wazuh.com/current/user-manual/user-administration/rbac.html#creating-and-setting-a-wazuh-read-only-user
Check List
yarn test:jest