Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace discover Configuration assessment #6285

Merged

Conversation

yenienserrano
Copy link
Member

Description

This PR, replaces the events tab on the Configuration assessment module

Issues Resolved

Evidence

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 9, 2024 12:49
@yenienserrano yenienserrano linked an issue Jan 9, 2024 that may be closed by this pull request
1 task
@yenienserrano yenienserrano self-assigned this Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 22.02% ( 176 / 799 )
Branches 19.55% ( 79 / 404 )
Functions 14.63% ( 36 / 246 )
Lines 22.23% ( 173 / 778 )

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.33% ( 171 / 224 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.33% ( 171 / 224 )

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Main plugin code coverage (Jest) test % values
Statements 11.41% ( 3918 / 34334 )
Branches 7.55% ( 1715 / 22687 )
Functions 11% ( 903 / 8204 )
Lines 11.58% ( 3807 / 32871 )

@jbiset jbiset self-requested a review January 9, 2024 13:27
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Tests

Configuration Assessment screen

image

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 🟢
Apply filters using the search bar add filter feature 🟢 🟢
Apply filters using the date picker 🟢 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢 🟢
  • Apply filters using search bar input

Chrome 🟢

image

Firefox 🟢

image

  • Apply filters using the search bar add filter feature

Chrome 🟢

image

Firefox 🟢

image

  • Apply filters using the date picker

Chrome 🟢

image

Firefox 🟢

image

  • Apply filters with no results (Check the No results match your search criteria message)

Chrome 🟢

image

Firefox 🟢

image

  • Use the saved queries feature (Check saved queries CRUD)

Chrome 🟢

Evidence_saved_query_chrome.webm

Firefox 🟢

Evidence_saved_query_firefox.webm

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢 🟢
  • Check histogram chart hits consistency

Chrome 🟢

Evidence_histogram_chart_consistency_chrome.webm

Firefox 🟢

Evidence_histogram_chart_consistency_firefox.webm
  • Use chart options (three points: maximize, minimize, inspect)

Chrome 🟢

Evidence_histogram_options_chrome.webm

Firefox 🟢

Evidence_histogram_options_firefox.webm

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 🟢
Check table pagination and rows per page 🟢 🟢
Check document detail flyout 🟢 🟢
  • Check all table header features (sort, show/hide columns, density, etc)

Chrome 🟢

Evidence_table_header_features_chrome.webm

Firefox 🟢

Evidence_table_header_features_firefox.webm
  • Check table pagination and rows per page

Chrome 🟢

Evidence_table_pagination_rowsperpage_chrome.webm

Firefox 🟢

Evidence_table_pagination_rowsperpage_firefox.webm
  • Check document detail flyout

Chrome 🟢

image

Firefox 🟢

image

@Machi3mfl Machi3mfl self-requested a review January 9, 2024 15:41
@Machi3mfl
Copy link
Member

Machi3mfl commented Jan 9, 2024

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input
Screen.Recording.2024-01-09.at.13.40.52.mov
  • Apply filters using the search bar add filter feature
Screen.Recording.2024-01-09.at.13.41.39.mov
  • Apply filters using the date picker
Screen.Recording.2024-01-09.at.13.42.45.mov
  • Apply filters with no results (Check the No results match your search criteria message)
Screen.Recording.2024-01-09.at.13.43.05.mov
  • Use the saved queries feature (Check saved queries CRUD)
Screen.Recording.2024-01-09.at.13.43.30.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency
Screen.Recording.2024-01-09.at.13.45.10.mov
  • Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-09.at.13.45.58.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-01-09.at.13.46.29.mov
  • Check table pagination and rows per page
Screen.Recording.2024-01-09.at.13.47.39.mov
  • Check document detail flyout
Screen.Recording.2024-01-09.at.13.48.50.mov

@asteriscos asteriscos merged commit b6ef617 into master Jan 9, 2024
1 of 4 checks passed
@asteriscos asteriscos deleted the feat/6276-replace-discover-configuration-assessment branch January 9, 2024 16:59
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Replace discover on configuration assessment module
4 participants