Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default vulnerabilities pattern health check to false #6321

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Change default vulnerabilities pattern health check to false #6321

merged 5 commits into from
Jan 18, 2024

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jan 15, 2024 •
edited
Loading

Description

This pull request change default vulnerabilities pattern health-check to false.

Issues Resolved

Evidence

Evidence.webm

Test

Check that when you log in, the health-check is executed and the vulnerability pattern check appears as disabled and the application continues to automatically redirect to the default screen.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Jan 15, 2024
@jbiset jbiset requested a review from a team as a code owner January 15, 2024 16:53
@jbiset jbiset linked an issue Jan 15, 2024 that may be closed by this pull request
Disable by default the vulnerabilities health-check #6319
Closed
Tostti
Tostti previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Test ✅
CR ✅

LGTM

Tostti
Tostti previously approved these changes Jan 16, 2024
View reviewed changes
yenienserrano
yenienserrano previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@asteriscos asteriscos dismissed stale reviews from yenienserrano and Tostti via f6fac02 January 18, 2024 11:15
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

yenienserrano
yenienserrano approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 4202 / 34417 )
Branches 8.26% ( 1911 / 23121 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4087 / 33009 )

@asteriscos asteriscos merged commit e4274d2 into 4.8.0 Jan 18, 2024
4 checks passed
@asteriscos asteriscos deleted the 6319-disable-by-default-the-vulnerabilities-health-check branch January 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@jbiset jbiset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable by default the vulnerabilities health-check
4 participants
@jbiset @Tostti @yenienserrano @asteriscos