Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the vulnerability pattern check in the health check #6396

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Feb 9, 2024

Description

This pull request removes the vulnerability pattern check in the health check and the related setting.

Changes:

  • Remove the vulnerability pattern check in the health check
  • Remove the setting checks.vulnerabilities.pattern

Issues Resolved

#6395

Evidence

image
image

node@osd:~/kbn/data/wazuh/config$ grep checks wazuh.yml
# checks.api: true
# checks.fields: true
# checks.maxBuckets: true
# checks.metaFields: true
# checks.pattern: true
# checks.setup: true
# checks.template: true
# checks.timeFilter: true

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
The check related to vulnerabilities shoud not appear in the health check
The checks.vulnerabilities.pattern should not appear in the App Settings application

Details

⚫ The check related to vulnerabilities shoud not appear in the health check

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ The `checks.vulnerabilities.pattern` should not appear in the App Settings application

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Other

Test Result
The checks.vulnerabilities.pattern should not appear in the initial configuration file

Details

⚫ The `checks.vulnerabilities.pattern` should not appear in the initial configuration file

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

- Remove the vulnerability pattern check in the health check
- Remove setting: checks.vulnerability.check
@Desvelao Desvelao self-assigned this Feb 9, 2024
@Desvelao Desvelao marked this pull request as ready for review February 9, 2024 10:52
@Desvelao Desvelao requested a review from a team as a code owner February 9, 2024 10:52
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Main plugin code coverage (Jest) test % values
Statements 12.29% ( 4250 / 34573 )
Branches 8.32% ( 1931 / 23206 )
Functions 11.71% ( 964 / 8228 )
Lines 12.47% ( 4136 / 33167 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

screencapture-localhost-5601-app-app-settings-2024-02-09-13_41_52

@JuanGarriuz
Copy link
Member

JuanGarriuz commented Feb 9, 2024

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
The check related to vulnerabilities shoud not appear in the health check 🟢
The checks.vulnerabilities.pattern should not appear in the App Settings application

Details

🟢 The check related to vulnerabilities shoud not appear in the health check

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 The `checks.vulnerabilities.pattern` should not appear in the App Settings application

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

Other

Test Result
The checks.vulnerabilities.pattern should not appear in the initial configuration file 🟢

Details

🟢 The `checks.vulnerabilities.pattern` should not appear in the initial configuration file

image

image

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image
image

@asteriscos asteriscos merged commit 2a85ef7 into 4.8.0 Feb 9, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6395-remove-vulnerability-pattern-from-health-check branch February 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health-check vulnerabilities index-pattern validation should be removed
4 participants