-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the vulnerability pattern check in the health check #6396
Remove the vulnerability pattern check in the health check #6396
Conversation
- Remove the vulnerability pattern check in the health check - Remove setting: checks.vulnerability.check
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestLegend: UI
Details 🟢 The check related to vulnerabilities shoud not appear in the health checkChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 The `checks.vulnerabilities.pattern` should not appear in the App Settings applicationChrome - 🟢 Firefox - ⚫ Safari - ⚫ Other
Details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This pull request removes the vulnerability pattern check in the health check and the related setting.
Changes:
checks.vulnerabilities.pattern
Issues Resolved
#6395
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
checks.vulnerabilities.pattern
should not appear in the App Settings applicationDetails
⚫ The check related to vulnerabilities shoud not appear in the health check
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ The `checks.vulnerabilities.pattern` should not appear in the App Settings application
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Other
checks.vulnerabilities.pattern
should not appear in the initial configuration fileDetails
⚫ The `checks.vulnerabilities.pattern` should not appear in the initial configuration file
Check List
yarn test:jest