-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster filter by default in vulnerabilities dashboard and inventory tab #6399
Add cluster filter by default in vulnerabilities dashboard and inventory tab #6399
Conversation
…rabilities-dashboard-and-inventory-tab
Test
Details 🟢 Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is enabled in the serverChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is disabled (manager mode) in the serverChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 With cluster is enabled in the server, navigate from Vulnerabilities Detection > Dashboard to Events must display the implicit filter of cluster.name and rule.groups:vulnerability-detectorChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 With cluster is disabled in the server, navigate from Vulnerabilities Detection > Dashboard to Events must display the implicit filter of manager.name and rule.groups:vulnerability-detectorFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard pins an agent and must add the implicit filterFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory pins an agent and must add the implicit filterFirefox - ⚫ Safari - ⚫ 🟢With a pinned agent in Vulnerabilities Detection > Dashboard go to Vulnerabilities Detection > Inventory and keep the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Inventory go to Vulnerabilities Detection > Dashboard and keep the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Inventory and must not display the filter related to the pinned agentChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agentChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Dashboard and must not display the filter related to the pinned agentChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agentChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Inventory must keep the regular filter.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Dashboard must keep the regular filter.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard defines a search that has no results, a sign "No results match your search criteria" should be displayedFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory defines a search that has no results, a sign "No results match your search criteria" should be displayedChrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard defines a search with results, go to Vulnerabilities Detection > Inventory and should not display a sign "No results match your search criteria"Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Invenoty defines a search with results, go to Vulnerabilities Detection > Dashboard and should not display a sign "No results match your search criteria"Firefox - ⚫ Safari - ⚫ |
UI
Details 🟢 Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is enabled in the serverFirefox - ⚫ Safari - ⚫ 🟢 Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is disabled (manager mode) in the serverFirefox - ⚫ Safari - ⚫ 🟡 With cluster is enabled in the server, navigate from Vulnerabilities Detection > Dashboard to Events must display the implicits filter of cluster.name and rule.groups:vulnerability-detectorFirefox - ⚫ Safari - ⚫ 🟢 With cluster is disabled in the server, navigate from Vulnerabilities Detection > Dashboard to Events must display the implicit filter of manager.name and rule.groups:vulnerability-detectorFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard pins an agent and must add the implicit filterFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory pins an agent and must add the implicit filterFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard go to Vulnerabilities Detection > Inventory and keep the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Inventory go to Vulnerabilities Detection > Dashboard and keep the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Inventory and must not display the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Dashboard and must not display the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟢 With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agentFirefox - ⚫ Safari - ⚫ 🟡 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Inventory must keep the regular filter.The regular filter is displayed in a different order. Firefox - ⚫ Safari - ⚫ 🟡 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Dashboard must keep the regular filter.The regular filter is displayed in a different order. Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.Firefox - ⚫ Safari - ⚫ 🟡 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.The regular filter is displayed in a different order. Firefox - ⚫ Safari - ⚫ 🟡 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.Firefox - ⚫ Safari - ⚫ 🟡 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard defines a search that has no results, a sign "No results match your search criteria" should be displayedFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Inventory defines a search that has no results, a sign "No results match your search criteria" should be displayedFirefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Dashboard defines a search with results, go to Vulnerabilities Detection > Inventory and should not display a sign "No results match your search criteria"Firefox - ⚫ Safari - ⚫ 🟢 In Vulnerabilities Detection > Invenoty defines a search with results, go to Vulnerabilities Detection > Dashboard and should not display a sign "No results match your search criteria"Firefox - ⚫ Safari - ⚫ |
Rare findingsValue stored in the session storage with data related to the alerts and vulnerabilities index pattern, that seems to be a filter: Request related to alerts index pattern (found by @JuanGarriuz): |
Test
Details 🟢 Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is enabled in the serverChrome - 🟢 🟢 Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is disabled (manager mode) in the serverChrome - 🟢 🟢 With cluster is enabled in the server, navigate from Vulnerabilities Detection > Dashboard to Events must display the implicit filter of cluster.name and rule.groups:vulnerability-detectorChrome - 🟢 🟢 With cluster is disabled in the server, navigate from Vulnerabilities Detection > Dashboard to Events must display the implicit filter of manager.name and rule.groups:vulnerability-detectorChrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard pins an agent and must add the implicit filterChrome - 🟢 🟢 In Vulnerabilities Detection > Inventory pins an agent and must add the implicit filterChrome - 🟢 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard go to Vulnerabilities Detection > Inventory and keep the filter related to the pinned agentChrome - 🟢 🟢 With a pinned agent in Vulnerabilities Detection > Inventory go to Vulnerabilities Detection > Dashboard and keep the filter related to the pinned agentChrome - 🟢 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Inventory and must not display the filter related to the pinned agentChrome - 🟢 🟢 With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agentChrome - 🟢 🟢 With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Dashboard and must not display the filter related to the pinned agentChrome - 🟢 🟢 With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agentChrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Inventory must keep the regular filter.Chrome - 🟢 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Dashboard must keep the regular filter.Chrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.Chrome - 🟢 🟢 In Vulnerabilities Detection > inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.Chrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.Chrome - 🟢 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.Chrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.Chrome - 🟢 🟢 In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.Chrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard defines a search that has no results, a sign "No results match your search criteria" should be displayedChrome - 🟢 🟢 In Vulnerabilities Detection > Inventory defines a search that has no results, a sign "No results match your search criteria" should be displayedChrome - 🟢 🟢 In Vulnerabilities Detection > Dashboard defines a search with results, go to Vulnerabilities Detection > Inventory and should not display a sign "No results match your search criteria"Chrome - 🟢 🟢 In Vulnerabilities Detection > Inventory defines a search with results, go to Vulnerabilities Detection > Dashboard and should not display a sign "No results match your search criteria"Chrome - 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
|
Description
This pull request adds the functionality for the vulnerability detector module to use the implicit
wazuh.cluster.name
filter, both when it is acluster
and when it is amanager
, because the vulnerability index pattern template does not havemanager.name
The above should only apply to the dashboard and inventory tabs. The Events tab should work with
manager.name
andcluster.name
normally and should have the implicit vulnerability detectorrule.groups
filterAdditionally, as a result of these changes, the following problems are solved:
No Results
functionality in Vulnerabilities Dashboard and InventoryIssues Resolved
Evidence
Vulnerability Dashboard tab
Vulnerability Inventory tab
Vulnerability Events tab
Screen capture evidence
screen-capture-evidence.webm
Test
Note
This test needs to have the vulnerability module activated from
appSettings
and insert data into the vulnerabilities index using the scriptdataInjectScript.py
which is inscripts/vulnerabilities-events-injector
Steps to test:
-Normal filters
wazuh.cluster.name
must appear, whether in amanager
or acluster
manager.name
/cluster.name
is respected and must be maintained as appropriaterule.groups
with the valuevulnerability-detector
should also appear in the Events tabLegend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is enabled in the server
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Vulnerability Detection > Dashboard must define the cluster filter using wazuh.cluster.name when the cluster is disabled (manager mode) in the server
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With cluster is enabled in the server, navigate from Vaulnerabilities Detection > Dashboard to Events must display the implicits filter of cluster.name and rule.groups:vulnerability-detector
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With cluster is disabled in the server, navigate from Vaulnerabilities Detection > Dashboard to Events must display the implicit filter of mananager.name and rule.groups:vulnerability-detector
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard pins an agent and must add the implicit filter
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Inventory pins an agent and must add the implicit filter
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a pinned agent in Vulnerabilities Detection > Dashboard go to Vulnerabilities Detection > Inventory and keep the filter related to the pinned agent
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a pinned agent in Vulnerabilities Detection > Inventory go to Vulnerabilities Detection > Dashboard and keep the filter related to the pinned agent
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Inventory and must not display the filter related to the pinned agent
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a pinned agent in Vulnerabilities Detection > Dashboard, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agent
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Dashboard and must not display the filter related to the pinned agent
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With a pinned agent in Vulnerabilities Detection > Inventory, unpin the agent, go to Vulnerabilities Detection > Events and must not display the filter related to the pinned agent
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Inventory must keep the regular filter.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Dashboard must keep the regular filter.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events must not keep the regular filter.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Inventory, and keep the filter you added previously in this view.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Inventory, add a regular filter (query or filter) and go to Vulnerabilities Detection > Events, go back to Vulnerabilities Detection > Dashboard, and keep the filter you added previously in this view.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard defines a search that has no results, a sign "No results match your search criteria" should be displayed
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Inventory defines a search that has no results, a sign "No results match your search criteria" should be displayed
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Dashboard defines a search with results, go to Vulnerabilities Detection > Inventory and should not display a sign "No results match your search criteria"
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Vulnerabilities Detection > Invenoty defines a search with results, go to Vulnerabilities Detection > Dashboard and should not display a sign "No results match your search criteria"
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check the operation in other modules, especially SCA and Office365
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest