Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the value to display in the Top 5 agents table in Vulnerabilities Detection dashboard #6424

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Change the value to display in the Top 5 agents table in Vulnerabilities Detection dashboard #6424

merged 3 commits into from
Feb 16, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Feb 16, 2024 •
edited
Loading

Description

This pull request replaces the value to display in the Top 5 agents table of Vulnerabilities Detection > Dashboard.

Issues Resolved

#6419

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With data, go to Vulnerabilities Detection > Dashboard, and the Top 5 agents must display the agent name ⚫ ⚫ ⚫

Details

⚫ With data, go to Vulnerabilities Detection > Dashboard, and the Top 5 agents must display the agent name

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao
feat(vulnerabilities-detection): display the agent.name in the Top 5 …
8e881b6 
…agents table of Vulnerabilities Detection > Dashboard
@Desvelao Desvelao requested a review from a team as a code owner February 16, 2024 09:26
@Desvelao Desvelao self-assigned this Feb 16, 2024
@Desvelao Desvelao linked an issue Feb 16, 2024 that may be closed by this pull request
Use agent.name in vulnerability dashboard table #6419
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

yenienserrano
yenienserrano approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4208 / 34677 )
Branches 8.2% ( 1907 / 23235 )
Functions 11.57% ( 956 / 8257 )
Lines 12.31% ( 4096 / 33271 )

@JuanGarriuz
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With data, go to Vulnerabilities Detection > Dashboard, and the Top 5 agents must display the agent name 🟢 ⚫ ⚫

Details

🟢 With data, go to Vulnerabilities Detection > Dashboard, and the Top 5 agents must display the agent name

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

JuanGarriuz
JuanGarriuz approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

asteriscos
asteriscos approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️
image

@asteriscos asteriscos merged commit cbe0d85 into 4.8.0 Feb 16, 2024
4 checks passed
@asteriscos asteriscos deleted the feat/6419-display-agent-name-top-5-agents-in-vulnerabilities-detection-dashboard branch February 16, 2024 11:28
@asteriscos asteriscos mentioned this pull request Feb 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use agent.name in vulnerability dashboard table
4 participants
@Desvelao @JuanGarriuz @asteriscos @yenienserrano