Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination improvements #646

Merged
merged 6 commits into from
Jul 2, 2018
Merged

Pagination improvements #646

merged 6 commits into from
Jul 2, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this PR fixes #645

Brief summary:

  • Monitoring module is now paginating agents by 500 items per request in order to fit new Wazuh API limits (Limit maximum result of API wazuh#875)
  • Wazuh table directive has been improved:
    • Single request has a 500 items limit
    • If we are in an empty page, it fetchs 500 more items and so on
    • Already fetched items are not re-fetched each time we are requesting data
    • Tables works the same way, this modification doesn't modify their behaviour, it only modifies the internal pagination
    • Some duplicated code has been placed into a common function

Regards,
Jesús

@jesusgn90 jesusgn90 added the type/enhancement Enhancement issue label Jul 2, 2018
@jesusgn90 jesusgn90 self-assigned this Jul 2, 2018
@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit 9291b35 into 3.3-6.3 Jul 2, 2018
@havidarou havidarou deleted the 3.3-6.3-issue-645 branch July 2, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants