Configuration factory #670

jesusgn90 · 2018-07-09T09:22:03Z

Hello team, this PR fixes #656

Now we have a new factory which stores all the configuration values
Added a new resolve function before each app route, this way we have the configuration always up to date
Also we are showing the current configuration under settings tab, this was added in 0f8ce06 but could be removed

Regards,
Jesús

havidarou · 2018-07-09T11:36:53Z

LGTM!

Jesús Ángel González added 7 commits July 9, 2018 10:40

Reading configuration from new config factory

1cddbfd

Factory to store values from configuration file

73a141f

Resolve function to parse configuration file

7185600

Importing new factory

6585cf1

Added new resolve function

78aba08

Exporting new resolve function

1f4f95f

Showing configuration file content in settings tab

0f8ce06

jesusgn90 added the bugfix label Jul 9, 2018

jesusgn90 self-assigned this Jul 9, 2018

jesusgn90 mentioned this pull request Jul 9, 2018

Create a new factory to manage the configuration file #656

Closed

Jesús Ángel González added 3 commits July 9, 2018 11:52

Fix typo

1afeaec

Updated config view

7f1de5e

Added nested resolves

25fbb74

havidarou merged commit 31870b8 into 3.3-6.3 Jul 9, 2018

This was referenced Jul 9, 2018

[3.2-6.2] Configuration factory #676

Closed

[3.3-6.2] Configuration factory #677

Closed

jesusgn90 deleted the issue-656 branch July 10, 2018 10:09

Provide feedback