Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #711: error on docker compose up #955

Closed
wants to merge 4 commits into from
Closed

Conversation

levisre
Copy link

@levisre levisre commented Aug 24, 2023

This PR fixes #711 which caused when user ran docker compose up in SELinux-enabled Host OS, by adding option for mount directives, as described in Docker Docs

@vcerenu vcerenu self-assigned this Mar 11, 2024
@vcerenu
Copy link
Member

vcerenu commented Mar 11, 2024

Hello @levisre
I am going to analyze this change since we have to ensure that it is compatible with other Linux distributions.
I ask you to resolve the conflicts before the merge since the master branch currently contains the development of v5.0.0

@vcerenu
Copy link
Member

vcerenu commented Mar 12, 2024

I am reviewing the PR and carrying out the tests, they have asked me that all the commits sent in the PR be signed, can you sign the first commit?

@teddytpc1 teddytpc1 linked an issue Mar 12, 2024 that may be closed by this pull request
5 tasks
levisre and others added 2 commits March 13, 2024 10:36
…o fix-711

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@levisre
Copy link
Author

levisre commented Mar 14, 2024

Nah, I couldn't sign the first commit, So can I close this PR and open the new one (with the signed commit)?

@levisre levisre closed this Mar 14, 2024
@levisre levisre deleted the fix-711 branch March 14, 2024 14:23
@levisre levisre mentioned this pull request Mar 14, 2024
@levisre
Copy link
Author

levisre commented Mar 14, 2024

Created a new PR: #1262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error bringing up contrainers - v4.3.6 Add :z option to mounted files
2 participants