Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the discard regex and field feature description and examples #6770

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Enhance the discard regex and field feature description and examples #6770

merged 1 commit into from
Nov 27, 2023

Conversation

fdalmaup
Copy link
Member

Description

Closes #6740. It adds more details regarding the discard_regex and field options and their usage examples to better guide the users when using this feature.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@fdalmaup fdalmaup self-assigned this Nov 17, 2023
@fdalmaup fdalmaup linked an issue Nov 17, 2023 that may be closed by this pull request
Clarify the functionality of the discard_regex tag in AWS #6740
Closed
GGP1
GGP1 requested changes Nov 17, 2023
View reviewed changes
source/user-manual/reference/ossec-conf/wodle-s3.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/wodle-s3.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/wodle-s3.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/wodle-s3.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/wodle-s3.rst Outdated Show resolved Hide resolved
@fdalmaup fdalmaup force-pushed the enhancement/6740-aws-discard-feature branch from 8a1b705 to d8a8023 Compare November 17, 2023 19:17
@fdalmaup fdalmaup requested a review from GGP1 November 17, 2023 19:17
GGP1
GGP1 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Selutario
Selutario suggested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Selutario Selutario left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I didn't review it on time to be included in 4.7.1, could you rebase it to 4.8.0 @fdalmaup? Thanks in advance.

@fdalmaup fdalmaup changed the base branch from 4.7.1 to 4.8.0 November 24, 2023 12:55
@fdalmaup fdalmaup force-pushed the enhancement/6740-aws-discard-feature branch from d8a8023 to d57f95c Compare November 24, 2023 12:55
@javimed javimed added type/enhancement Enhancement issue level/task Task issue labels Nov 24, 2023
@fdalmaup fdalmaup force-pushed the enhancement/6740-aws-discard-feature branch from d57f95c to 5c795e9 Compare November 27, 2023 12:02
@fdalmaup fdalmaup force-pushed the enhancement/6740-aws-discard-feature branch from 5c795e9 to f70f23a Compare November 27, 2023 13:53
@javimed javimed merged commit d0d3c3f into 4.8.0 Nov 27, 2023
@javimed javimed deleted the enhancement/6740-aws-discard-feature branch November 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selutario Selutario Selutario approved these changes

@javimed javimed javimed approved these changes

@GGP1 GGP1 GGP1 approved these changes

Assignees

@fdalmaup fdalmaup

Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Release 4.8.0
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify the functionality of the discard_regex tag in AWS
4 participants
@fdalmaup @Selutario @javimed @GGP1