Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urllib3 library version #6824

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented Dec 1, 2023

Description

Adds the urllib3==1.26.18 library to be compatible with the docker version used.

Used 4.7.2 as the base branch because it's the version used in production and this needs to be fixed as soon as possible.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@GGP1 GGP1 self-assigned this Dec 1, 2023
@GGP1 GGP1 linked an issue Dec 1, 2023 that may be closed by this pull request
4 tasks
@fdalmaup fdalmaup self-requested a review December 1, 2023 18:24
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the dependencies in our requirements.txt file force the version to be docker==4.2.0 and urllib3==1.26.5, if we change the documentation to be docker==6.1.1 we would need to modify these in the embedded interpreter to keep consistency.

An alternative to this could be adding the urllib3==1.26.5 version in the docs commands to limit the searched urllib since it is required to be >=1.21.1, and open an issue to upgrade docker for a minor version. Also, consider that an update on the urllib3 dependency is currently ongoing.

Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @fdalmaup mentioned, urllib3 is being upgraded to 1.26.18 to fix some vulnerabilities.

Since said change is just a patch, there should be no compatibility issues, but can you ensure that this is the case and, if so, use said version in the docu as well? This way we prevent users from installing a version with known vulnerabilities (1.26.5).

It would also be nice to open a new issue to upgrade the docker version in the future, both in the embedded python and in the documentation for agents.

@GGP1 GGP1 changed the title Update docker library version Update urllib3 library version Dec 4, 2023
@GGP1 GGP1 force-pushed the fix/20372-docker-listener-wodle branch from dd910e4 to 43394de Compare December 4, 2023 13:59
@javimed javimed changed the title Update urllib3 library version Update urllib3 librRelease notesary version Dec 6, 2023
@javimed javimed added level/task Task issue type/bug Bug issue labels Dec 6, 2023
@javimed javimed merged commit 3edcd62 into 4.7.2 Dec 6, 2023
@javimed javimed deleted the fix/20372-docker-listener-wodle branch December 6, 2023 13:31
@javimed javimed changed the title Update urllib3 librRelease notesary version Update urllib3 library version Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docker listener is unable to connect to docker daemon
4 participants