-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update urllib3 library version #6824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the dependencies in our requirements.txt file force the version to be docker==4.2.0
and urllib3==1.26.5
, if we change the documentation to be docker==6.1.1
we would need to modify these in the embedded interpreter to keep consistency.
An alternative to this could be adding the urllib3==1.26.5
version in the docs commands to limit the searched urllib
since it is required to be >=1.21.1
, and open an issue to upgrade docker
for a minor version. Also, consider that an update on the urllib3
dependency is currently ongoing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @fdalmaup mentioned, urllib3 is being upgraded to 1.26.18
to fix some vulnerabilities.
Since said change is just a patch, there should be no compatibility issues, but can you ensure that this is the case and, if so, use said version in the docu as well? This way we prevent users from installing a version with known vulnerabilities (1.26.5
).
It would also be nice to open a new issue to upgrade the docker version in the future, both in the embedded python and in the documentation for agents.
dd910e4
to
43394de
Compare
Description
Adds the
urllib3==1.26.18
library to be compatible with thedocker
version used.Checks
Docs building
Code formatting and web optimization
redirects.js
script if necessary (check this guide).Writing style
code
font for Bash commands, file names, REST paths, and code.