Notify when you are registering an agent without permissions #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion fix tcp sessions visualizations
* First commit added testlog view and menu with navigation to dev console and testlogs. * Added reducers for tools. * Added PUT request logtest and pretty json. * Clear initial value. * Apply prettier. * Fixed pined menu selected. Change some files js to ts. Added updateSelectedToolsSection redux. * Removed debuggers * Fix error on render elements * Fix render items * Fixed error on tabs * Updated CHANGELOG * Added flyout from ruleset edit and fixed styles. * Added OverlayMask and event to close. * Changed title of Logtest * Fixed styles, PR comments.
* fix(health-check): fix creation of default index-pattern * test(fix): Added getExistingIndexPattern method, fix queryParams of get. * test(fix): PR comments * fix(health-check): Added validation before createWazuhIndexPattern. * bugfix(health-check): Added all section create and refresh index in healthcheck. * fix: some bad behaviors * doc(changelog): add fix to changelog * fix: add missing basePath * fix: reject promise on error * feat: refactor required fields * feat: refactor const * fix: remove unused import * fix(health-check): Clear unnecessary returns and imports + prettier. Co-authored-by: Franco Charriol <francocharriol@gmail.com>
…the agent (#3238) * feat(frontend): Added a warning message in the command to install and enroll an agent * changelog: Added PR to changelog * fix: remove NODE_TLS_REJECT_UNAUTHORIZED warning * Fix index validation
* fix: default pattern always is set as selected pattern * doc: update changelog
…into fix/3406-notify-register-agent-without-permissions
…ttps://github.com/wazuh/wazuh-kibana-app into fix/3406-notify-register-agent-without-permissions
frankeros
reviewed
Jul 2, 2021
| {(!this.state.needsPassword && this.state.wazuhPassword=== "") ? ( | ||
| <EuiCallOut | ||
| color="warning" | ||
| title={<> This section could not be displayed because you do not have permission to get access to the registration service. </>} |
There was a problem hiding this comment.
why registration service? maybe authorization coniguration (?)
There was a problem hiding this comment.
response:
Wazuh documentation about the configuration that is requested:
https://documentation.wazuh.com/current/user-manual/reference/ossec-conf/auth.html#auth
There was a problem hiding this comment.
I think to have a relationship with the documentation. we should leave it like this
Desvelao
reviewed
Jul 5, 2021
| @@ -473,7 +485,14 @@ export const RegisterAgent = withErrorBoundary( | |||
|
|
|||
| const guide = ( | |||
| <div> | |||
| {this.state.selectedOS && ( | |||
| {(!this.state.needsPassword && this.state.wazuhPassword=== "") ? ( | |||
There was a problem hiding this comment.
thought: I am not sure about this check to display the callout. Maybe we should have a state when the request fails.
There was a problem hiding this comment.
hmmm... I'm going to check this
There was a problem hiding this comment.
review:
I tested the PR and when there isn't a configurated password, the callout is displaying:
registration service info and display the callout - Applied the callout to some steps whene there is a error to get the registratrion service info - Changed the callout from warning to danger - Fix not reported errors, when the user has not permissions, some selectors didn't display
Changes
|
|
gabiwassan
pushed a commit
that referenced
this pull request
Jul 30, 2021
* fix(frontend_register_agent): Fix when there was an error to get the registration service info and display the callout - Applied the callout to some steps whene there is a error to get the registratrion service info - Changed the callout from warning to danger - Fix not reported errors, when the user has not permissions, some selectors didn't display
gabiwassan
pushed a commit
that referenced
this pull request
Aug 5, 2021
* fix(frontend_register_agent): Fix when there was an error to get the registration service info and display the callout - Applied the callout to some steps whene there is a error to get the registratrion service info - Changed the callout from warning to danger - Fix not reported errors, when the user has not permissions, some selectors didn't display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
In this PR, we have added a notification when it is not possible to change the group for this agent due to lack of permissions and we have hidden the command option when we do not have permission to access the manager's password since this made the command erroneous.
In order to test It:
We would have to enter with a user with group permissions and access the manager's password and see that neither of the two posters is shown.
Then we would have to enter with a user without both permissions and see that both permissions are activated.
Close #3406