-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulnerability inventory rework #3893
Merged
Desvelao
merged 39 commits into
4.3-7.10
from
enhance/vulnerability-inventory-rework-3883
Mar 21, 2022
Merged
Vulnerability inventory rework #3893
Desvelao
merged 39 commits into
4.3-7.10
from
enhance/vulnerability-inventory-rework-3883
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 11, 2022
- Created charts components: - Donut - Created visulizations - Created visualiation widgets - Simple - Selector: add a switch to choose an option - Replaced visualization of Compliance in Agent overview - Add visualization to Vulnerabilities/Inventory - Update Wazuh API data Update Wazuh API data - Endpoints - Security
… Add more fields to summary visualization in Modules/Vulnerabilities/Inventory
…/github.com/wazuh/wazuh-kibana-app into enhance/vulnerability-inventory-rework-3883
… fixes: - Removed console.log in fetching function of compliance visualization - Removed deprecated state in Vulnerability/Inventory
Desvelao
reviewed
Mar 18, 2022
Desvelao
reviewed
Mar 18, 2022
Desvelao
reviewed
Mar 18, 2022
Desvelao
reviewed
Mar 18, 2022
Desvelao
reviewed
Mar 18, 2022
Desvelao
reviewed
Mar 18, 2022
Desvelao
reviewed
Mar 18, 2022
yenienserrano
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test: ✔️
Fixed:
Not fixed. We will take in account this problem. |
|
This was referenced Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
this PR removes Vulnerability dashboard, adds visualizations to Vulnerability inventory and enhances Details Flyout fields.
Changes
UI
Dashboard
tab ofVulnerabilities
module.agent
andoverview
(no selected agent)Vulnerabilities/Inventory
:Severity
: visualizationDetails
: statsSummary
: visualization with selector by fieldcondition
external_references
published
title
updated
data.vulnerability.status
to the table ofVulnerabilites/Events
Logic
React components
Compliance
panel in the agent summary dashbaord to reusable components.VisualizationBasic
,VisualizationBasicWidget
andVisualizationBasicSelector
components.React hooks
useAsyncActionRunOnStart
hook.Screenshots
Closes #3883 and #3890
Test
Modules/Vulnerabilites
Inventory
.Dashboard
tab was removed.Modules/Vulnerabilities/Inventory
Severity
panel:No results
messageCritical
,High
,Medium
andLow
from left to rightlast full scan
andlast partial scan
stats display as-
.Summary
panel:No results
messageSeverity
panel:Critical
,High
,Medium
andLow
Critical
,High
,Medium
andLow
from left to rightlast full scan
andlast partial scan
stats' format depends on the plugin platform date format.Summary
panel:Severity
panel andDetails
should match their colors.Modules/Inventory/Events
data.vulnerability.status
Side effects
Compliance
in the agent summary section work as expected.No results
prompt.Compliance
panel should adjust to the layout depending on the window width.Theme mode
light
anddark
mode.