-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firewall validation in the installation assistant #2555
Merged
teddytpc1
merged 8 commits into
4.7.0
from
enhancement/2539-wazuh-deployment-on-rocky-linux-8-ignore-option-leads-to-communication-issues-to4.7.0
Oct 25, 2023
Merged
Firewall validation in the installation assistant #2555
teddytpc1
merged 8 commits into
4.7.0
from
enhancement/2539-wazuh-deployment-on-rocky-linux-8-ignore-option-leads-to-communication-issues-to4.7.0
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddytpc1
previously approved these changes
Oct 24, 2023
davidcr01
reviewed
Oct 25, 2023
davidcr01
reviewed
Oct 25, 2023
davidcr01
suggested changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ! Please, consider changing the title of the PR and the suggested changes. Try to improve the messages listing the ports with commas.
Co-authored-by: David Correa Rodríguez <72193239+davidcr01@users.noreply.github.com>
Co-authored-by: David Correa Rodríguez <72193239+davidcr01@users.noreply.github.com>
c-bordon
changed the title
Enhancement/2539 wazuh deployment on rocky linux 8 ignore option leads to communication issues to4.7.0
Firewall validation in the installation assistant
Oct 25, 2023
teddytpc1
approved these changes
Oct 25, 2023
davidcr01
approved these changes
Oct 25, 2023
teddytpc1
deleted the
enhancement/2539-wazuh-deployment-on-rocky-linux-8-ignore-option-leads-to-communication-issues-to4.7.0
branch
October 25, 2023 13:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validations are created to detect if the system has Firewalld or UFW installed and enabled, to indicate by a Warning message which ports should be opened in the firewall
Logs example
Ubuntu Jammy:
Firewalld: #2539 (comment)
Without Firewalld: #2539 (comment)
Firewalld and UFW: #2539 (comment)
Rocky Linux 8:
Firewalld: #2539 (comment)
Without Firewalld: #2539 (comment)
Firewalld and UFW: #2539 (comment)
Tests
Centos 7: https://ci.wazuh.info/view/Tests/job/Test_unattended/4553/console
Ubuntu Bionic: https://ci.wazuh.info/view/Tests/job/Test_unattended/4554/console
Distributed: https://ci.wazuh.info/view/Tests/job/Test_unattended_distributed/548/console