Added check when generating certificates for multiple DNS #3006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to add a check in the certificates generation. This check ensures that every DNS specified in the
config.yml
file was valid. This comprobation was already done by the certificates tool, but it was enhanced to cover the multiple DNS use case:Before
With the following YAML file, the certificates were created. Notice that the
localhost
DNS is invalid:After
Now, with the check, the invalid DNS is fetched and the certificates generation is stopped.
Testing
The performed testing is in the following comment: #2371 (comment). Also, it has been checked that this change does not affect to the IP certificates generation.