Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving pages in workspace draft mode no more possible due to an exception error #33

Closed
claude27 opened this issue Jul 1, 2020 · 4 comments
Labels
feedback needed help wanted Extra attention is needed

Comments

@claude27
Copy link

claude27 commented Jul 1, 2020

It's no more possible to move pages in the page tree in workspace draft mode.

This is caused by an exception error:
Core: Exception handler (WEB): Uncaught TYPO3 Exception: Argument 1 passed to Wazum\Sluggi\Backend\Hook\DatamapHook::getLastSlugSegment() must be of the type string, null given, called in /xxx/public/typo3conf/ext/sluggi/Classes/Backend/Hook/DatamapHook.php on line 251 | TypeError thrown in file /xxx/public/typo3conf/ext/sluggi/Classes/Backend/Hook/DatamapHook.php in line 652.

How can this prevented?

@wazum
Copy link
Owner

wazum commented Jul 28, 2020

@claude27 unfortunately I'm not using workspaces in any of my projects, so it's a bit hard for me to test with this stuff.
It looks like the requested page has no slug value

$currentPage = BackendUtility::getRecord('pages', $id, 'uid, slug, sys_language_uid');
…
$currentSlugSegment = $this->getLastSlugSegment($currentPage['slug']);

Would be very helpful if you step through this part with a debugger and report what's going on.

@wazum
Copy link
Owner

wazum commented Nov 11, 2020

@claude27 please check out the new version for TYPO3 CMS 10 (2.0), if you can see the same problem there

@wazum wazum added feedback needed help wanted Extra attention is needed labels Nov 12, 2020
gianstraf added a commit to gianstraf/sluggi that referenced this issue Apr 19, 2021
- wazum#33, move page into a workspace
- Manage the slug update for the moved page recursively, into a workspace
@supercaccia
Copy link

I confirm that I have tested @gianstra 's patch and it works in draft!

After this bug is fixed https://review.typo3.org/c/Packages/TYPO3.CMS/+/68182 in TYPO3 10.4.14 and sluggi patch #56 the behaviors are more and more similar with "vintage" RealURL :)

Thanks to @wazum and @gianstraf !!!

@wazum
Copy link
Owner

wazum commented Feb 18, 2022

Version 3+ (for TYPO3 11) should now be compatible with Workspaces

@wazum wazum closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback needed help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants