fix compilation on macOS #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedahan
commented
Oct 1, 2018
| @@ -44,7 +51,7 @@ ifeq (${DARWIN_CC},) | |||
| DARWIN_CC := $(shell which gcc) | |||
| EXTRA_CFLAGS := | |||
| else | |||
| EXTRA_CFLAGS := -fvectorize -fslp-vectorize -fslp-vectorize-aggressive -pthread | |||
| EXTRA_CFLAGS := -fvectorize -fslp-vectorize -pthread | |||
There was a problem hiding this comment.
clang has deprecated this flag
| #CFLAGS += -march=pentium3 -sse | ||
| CFLAGS += -march=native |
There was a problem hiding this comment.
should i re-include -std=gnu99?
| @@ -85,6 +85,7 @@ if [ ! -z "$selected_sdk" ]; then | |||
|
|
|||
| # Remove the "u" if 10.4u Universal SDK is used. | |||
| min_str="${min_str%%u}" | |||
| min_str="${min_str:-10.14}" | |||
There was a problem hiding this comment.
Just some safety net
|
Merged into dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the changes I needed to get working on macOS 10.12.3 and homebrew.
I had to do
maketwice, and there are a few warnings leftover from clang about unused linker flags, but it seems to work well enough.I haven't tested these changes with macPorts.