Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

Add locale to preview path #3

Closed
wants to merge 7 commits into from
Closed

Conversation

tiacop
Copy link

@tiacop tiacop commented Sep 15, 2020

If the datoCMS project is multilang add the locale to the preview path

Copy link
Owner

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you intend to publish your own fork of this plugin? I can't accept this PR as submitted, as it changes a lot of underlying things (module name, author etc.)

Appreciate the example code of pulling the locale from a field though, I may use this to rework the plugin as outlined here: #2 (comment) and include locale as one of the fields.

@tiacop
Copy link
Author

tiacop commented Sep 15, 2020

Thanks for your answer and it's OK! I thought, having so many preview plugins is confusing, but in the end I forked yours and i'm working on a "multilang & field addon" ... https://github.com/tiacop/datocms-plugin-nextjs-preview. So the preview link can no longer be overlooked :)

@wbobeirne
Copy link
Owner

Sounds good, feel free to keep riffing on that one!

@wbobeirne wbobeirne closed this Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants