Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libc++ flag to setup.py #107

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Add libc++ flag to setup.py #107

merged 1 commit into from
Oct 16, 2019

Conversation

schmty
Copy link
Contributor

@schmty schmty commented Oct 15, 2019

Fixes #106

wbolster
wbolster requested changes Oct 15, 2019
View reviewed changes
Copy link
Owner

@wbolster wbolster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the CI builds. (check the travis build logs)

gcc: error: unrecognized command line option ‘-stdlib=libc++’

@schmty schmty closed this Oct 16, 2019
@schmty schmty reopened this Oct 16, 2019
@schmty
Copy link
Contributor Author

schmty commented Oct 16, 2019

Ah, forgot other platforms will use gcc instead of clang, since this is mac specific, I had to add platform back, should be working now

@schmty schmty requested a review from wbolster October 16, 2019 04:58
wbolster
wbolster approved these changes Oct 16, 2019
View reviewed changes
Copy link
Owner

@wbolster wbolster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not on osx myself, but looks good

@wbolster wbolster merged commit 1ffdb90 into wbolster:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbolster wbolster wbolster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Installing pyvel 1.1.0 on MacOS Via pip
2 participants
@schmty @wbolster