-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose DB name attribute at the Python level #90
Conversation
thanks, is there a way to make the attribute read only? |
Oh, that is a very good point. Will do! |
25d91df
to
334651c
Compare
@wbolster See re-worked commit. The Just in case that helps, I found the following docs useful https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#static-attributes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, looking good.
can you add the documentation to the api docs with a proper version tag? (use 1.1.0)
Yes! |
334651c
to
f52dc26
Compare
f52dc26
to
fb3bdb5
Compare
@wbolster Added docs with a note about the version. Let me know if anything else needs to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool
Related to issue #88.
The
DB.name
attribute is not exposed at the Python level and could sometimes be useful. One example, is the deletion of a DB instance for which thename
has not been "cached" at creation time. One could get the name by parsingDB.__str__()
orDB.__repr__()
but why not directly fromDB.name
?