Fix a crash during CRL verification #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `use_deltas` was set to True as an input to the `verify_crl` function
the code would proceed to build the following list of distribution point
objects in `sources`:
`[[dp, dp, ...], dp, dp, ...]`
The code after assumed the following format:
`[[dp, dp, ...], [dp, dp, ...]]` (a list of lists)
This divide could lead to a crash due to a `TypeError`.
The fix implemented in this commit removes the nesting of lists as it is
not needed, so the new format is:
`[dp, dp, ..., dp, dp, ...]`
|
I just came across this issue too and was about to submit a pull request for this and saw this one. My solution was slightly different by just changing It seems rare to see this for a cert for me. |
This was referenced Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
use_deltaswas set to True as an input to theverify_crlfunction the code would proceed to build the following list of distribution point objects insources:[[dp, dp, ...], dp, dp, ...]The code after assumed the following format:
[[dp, dp, ...], [dp, dp, ...]](a list of lists)This divide could lead to a crash due to a
TypeError, as described in #9.The fix implemented in this PR removes the nesting of lists as it is not needed, so the new format is:
[dp, dp, ..., dp, dp, ...]