Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C++ support for abs operator #53

Closed
wants to merge 1 commit into from

Conversation

pablrod
Copy link
Contributor

@pablrod pablrod commented Jul 8, 2016

I've tested this with a modified version of 13_generate.t. But it isn't included in this pull request.
Also named operators now delegate C++ ops and types code generation to operator.

@wbraswell
Copy link
Owner

wbraswell commented Jul 9, 2016

Hi @pablrod , it looks like your 3 .CPPOPS_CPPTYPES output files were generated using an old (and broken) Print.pm generator, because they are incorrectly using commas instead of the double-less-than << argument separator for the cout operator. Also, the new corrected version of RPerl does not always need to prepend (const string) to every argument, and uses 'print' instead of 'cout'.

9b9dbf3#diff-6ffbdbfdae77767f07ef4810a91445bfR14

WRONG:
cout << (const string) "have $foo = ", foo, (const string) "\n";

RIGHT
print << "have $foo = " << foo << "\n";

I have just released RPerl v2.0 to CPAN, and of course the latest Github code is even more up to date than that. I have totally refactored t/13_generate.t and lots of other associated code. Please make sure you are upgraded to RPerl v2.0, then test out your new changes and we can try it again. It is okay if Appveyor fails because I have not yet got it working totally, but we do not want Travis to fail.

Thanks and keep up the great work! :-)

@pablrod
Copy link
Contributor Author

pablrod commented Jul 9, 2016

Yes, you're right. I've used an outdated Print.pm generator. I'm fixing this!

@wbraswell
Copy link
Owner

Okay great, please make sure you pull the latest code from Github, because lots of files have changed, not just Print.pm. I am closing this pull request so that you can open a new pull request when you are ready. Thanks! :-)

@wbraswell wbraswell closed this Jul 9, 2016
@pablrod pablrod deleted the feature/abs_operator_cpp branch July 10, 2016 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants