Support two Elasticsearch clusters #602
Conversation
|
Is this still a WIP? |
|
|
||
| protected function getQueryParams(): string { | ||
| return parent::getQueryParams() . '&cluster=' . $this->cluster(); |
There was a problem hiding this comment.
@AndrewKostka I'm currently looking into moving this forward and there's a high-level question I'd like to ask here: what's the reason you decided to have api be in control over which clusters the maintenance scripts are invoked for, when instead this could also be handled by our wrappers in MediaWiki themselves? E.g. by default it seems most CirrusSearch maintenance scripts already work on all known clusters by default.
There was a problem hiding this comment.
What's the reason you decided to have api be in control over which clusters the maintenance scripts are invoked for, when instead this could also be handled by our wrappers in MediaWiki themselves?
Our current process for running maintenance scripts requires us to fire off a job in the API rather than interfacing directly with MediaWiki. If we need to run UpdateSearchIndexConfig on a new cluster or force an index update using ForceSearchIndex, these actions must/should only be run on a specific cluster. Hence, why we need to specify which cluster should be the target for a specific maintenance script. If we were to directly run maintenance scripts from MediaWiki, thus dropping the cURL dependency between the API and MediaWiki, we could choose to only update the wrappers in MediaWiki.
E.g. by default it seems most CirrusSearch maintenance scripts already work on all known clusters by default.
AFAIK the CirrusSearch maintenance scripts do not work on all clusters by default.
Maintenance tasks (update mapping, reindex, etc.) must be performed per
CirrusSearch cluster. CirrusSearch maintenance scripts all take a--cluster
option to specify the CirrusSearch cluster to operate on. When not specified
the default search cluster is used. Informational maintenance scripts that
can not change any state may choose to emit for all clusters when--cluster
is not provided.
There was a problem hiding this comment.
AFAIK the CirrusSearch maintenance scripts do not work on all clusters by default.
Interesting. The script level documentation / comments say differently, but it's probably best to be explicit in that case.
|
Closing this in favor of #624 |
No description provided.