feat(wiki): add WikiSiteStats model #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Aug 21, 2023
| }); | ||
|
|
||
| Schema::table('wikis', function (Blueprint $table) { | ||
| $table->text('description')->nullable(); |
There was a problem hiding this comment.
This is limited to 64kb of text, which I guess is ok. longText could store 4GB of text which might be a bit too long for a snappy description.
Closed
tarrow
approved these changes
Aug 22, 2023
deer-wmde
pushed a commit
that referenced
this pull request
Aug 22, 2023
* feat(wiki): add WikiSiteStats model * fix(migrations): string field is too limited for storing description * fix: make new wiki fields fillable * docs: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T344580
This PR intentionally does not create any records based on the newly introduced model yet. Right now, when querying for a wiki and including the
wikiSiteStatsrelation, it would just returnnull.