feat: emit metrics about entity imports #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Jul 23, 2024
m90
force-pushed
the
feature/data-reuse-tool
branch
from
c3d0fb1
to
32c2862
Compare
m90
force-pushed
the
fr/import-metrics
branch
2 times, most recently
from
5da31a6
to
3745738
Compare
m90
force-pushed
the
fr/import-metrics
branch
2 times, most recently
from
dc934a3
to
d4181a6
Compare
m90
commented
Aug 6, 2024
|
|
||
| public function __construct(CollectorRegistry $registry) | ||
| { | ||
| $this->successfulCounter = $registry->getOrRegisterCounter( |
There was a problem hiding this comment.
There's a tricky decision here: if we define these counters only once, it means they will be missing from the metrics if they have never been increased yet (the controller that answers the scraper will not know about it yet as it's never been persisted).
Alternatively we could:
- duplicate this definition in the
Metrics/WikiEntityImportclass - move all metrics definitions to the service provider and have stub
metricsmethods on the metrics classes themselves
There was a problem hiding this comment.
If I understand right this isn't really a big problem? It just means that instead of 0 we will have null until the first import?
m90
commented
Aug 6, 2024
config/database.php
Outdated
| 'host' => env('REDIS_HOST', '127.0.0.1'), | ||
| 'password' => env('REDIS_PASSWORD', null), | ||
| 'port' => env('REDIS_PORT', 6379), | ||
| 'database' => env('REDIS_METRICS_DB', 2), |
There was a problem hiding this comment.
This is not supported by the Prometheus library that just uses a hardcoded PROMETHEUS_ prefix on keys. I shall remove the setting again.
tarrow
approved these changes
Aug 12, 2024
tarrow
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T370799