Support sharing Elasticsearch indices across multiple wikis #430
Conversation
There was a problem hiding this comment.
Looks fine to me; I don't want to hold trying this up on staging but I still think this could make sense perhaps to move to the platform api if possible. I'm struggling to see if we can avoid this surgery in the validate index method and instead successfully validate the alias.
| * @return \Elastica\Index being updated | ||
| */ | ||
| public function getRealIndex() { | ||
| return $this->indexSharedName ? $this->getSharedIndex() : $this->getIndex(); |
There was a problem hiding this comment.
praise: It's nice that this is a no-op without the extra ENV being set
| /** | ||
| * @return \Elastica\Index being updated | ||
| */ | ||
| public function getRealIndex() { |
There was a problem hiding this comment.
suggestion: this can probably be a private method (I really hope we never see a reason to call this from anywhere else)
suggestion: should this have a name other than "real"? perhaps "getNotAliasedIndex"?
There was a problem hiding this comment.
Nice! I updated both in the latest commit
Let's see how this works on staging but it's definitely possible to create aliases from the platform API |
No description provided.