Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WikiSettings): Add QuestyCaptcha card to Wiki Settings #760

Merged
merged 30 commits into from
Jan 25, 2024

Conversation

dati18
Copy link
Contributor

@dati18 dati18 commented Dec 8, 2023

No description provided.

Copy link

github-actions bot commented Dec 8, 2023

Deployment previews on netlify for branch refs/pull/760/merge will be at the following locations (when build is done):

@AndrewKostka
Copy link
Contributor

re:How to hide the arrow in a v-combobox?

Here's a hacky way to do it using CSS:

<v-combobox
  class="answer-box"
  ...
>>> .answer-box .v-input__append-inner {
  display: none !important;
}

<v-col class="checkbox">
<v-checkbox label="Activate spam protection" v-model="captchaActivate"></v-checkbox>
</v-col>
<!-- Setting Panel-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can totally see why you added these comments but in general this might be a sign that in future it would be best to split up this single one large card into multiple smaller components that could also have similarly descriptive names. Let's not change this now though

:items="entry.answers"
multiple
outlined
:rules="[required]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be slightly clearer to either inline this rule or change the method name to something more descriptive than required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<v-checkbox label="Activate spam protection" v-model="captchaActivate"></v-checkbox>
</v-col>
<!-- Setting Panel-->
<v-expansion-panels v-model="panel">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the reason nothing is working; is this v-model new? Right now its referencing a thing (called panel that's not there) see the error in the browser console:

[Vue warn]: Property or method "panel" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in

---> <QuestyCaptcha> at src/components/Pages/ManageWiki/Cards/QuestyCaptcha.vue
       <VMain>
         <ManageWiki> at src/components/Pages/ManageWiki/Tabs/ManageWiki.vue
           <VTabItem>
             <VTabsItems>
               <TabSettings> at src/components/Pages/ManageWiki/TabSettings.vue
                 <VApp>
                   <App> at src/App.vue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, it was added there to collapse the panel when saving is done (as Charlie said).

https://github.com/wbstack/ui/pull/760/files#:~:text=%7D)-,this.panel%20%3D%20false,-%7D)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tarrow tarrow merged commit 4e270cd into main Jan 25, 2024
7 checks passed
@tarrow tarrow deleted the questy-captcha-ui branch January 25, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants