Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume/skip arrays #113

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Consume/skip arrays #113

merged 2 commits into from
Apr 2, 2019

Conversation

lundmark
Copy link
Collaborator

@lundmark lundmark commented Apr 1, 2019

We had some parsing issues with some of our entities due to the array-skip missing. It's now fixed.

@lundmark
Consume/skip arrays
9831f8b 
We had some parsing issues with some of our entities due to the array-skip missing. It's now fixed.
@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 92.25% when pulling dc0aeb4 on lundmark:master into a1e3824 on wc-duck:master.

@lundmark
Copy link
Collaborator Author

lundmark commented Apr 1, 2019

I don't understand why this would decrease coverage? Is that really an issue in this case?

@wc-duck
Copy link
Owner

wc-duck commented Apr 1, 2019

Could you provide a test for this one?

@lundmark
Copy link
Collaborator Author

lundmark commented Apr 2, 2019

Unfortunately I'm not sure I remember the testcase :/ I'll try to see if I can get one.

@wc-duck wc-duck merged commit 5fafcef into wc-duck:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wc-duck wc-duck wc-duck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lundmark @coveralls @wc-duck