Const / comment feature and some minor cleanups. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync to latest.
Removed unneccessary includes and changed malloc/free to use dl internal allocator.
Types, enums, members and unions now support the tag "comment" which is a string that is prepended before the enum/member/type/union declaration. Members now also support a "const" tag where you can set it to "false" (boolean) to make the pointer non-const.
I missed copying in the include/ directory (for the dl_reflect.h) when moving over my changes to git. Plus there had been some changes that I didn't notice when merging so I had to clean those up as well.
|
I don't like merging PR:s to master with outstanding comments/issues :( |
|
Sorry I never saw any comments/issues made that were tagged with this PR. Fixes are incoming for the allocator-issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to make these into separate PR's but apparently you can't have multiple commits in your fork and create separate PR's from them. Sorry about that. Fortunately two of these commits are really simple (only cleanups).
This is the const and comment-options that we talked about. I know that the const-feature isn't the exact implementation that we had discussed (it uses a flag instead of parses it from the type declaration). But I I think it's probably better if you handle the parsing. If you think that I should fix it, just let me know and I'll get on it.
The comment-feature isn't fully unit-tested, and I didn't throw it into one of the type libraries (only tried it locally on my type library) and it seems to work fine. Maybe I should add it to each of the different features that support it just so that the code is run?
Cheers,
Simon