Removed "Characters" keyword to match grDevices #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm reluctant to change any of the C code, though, since I'm just using the pristine, untouched sources from ttf2pt1, and I'd like to keep it that way. I know it's uglier, but do you mind modifying the For example, perhaps add a function to strip the "Characters" line and call it here: https://github.com/wch/extrafont/blob/freetype/R/truetype.r#L90 |
|
Fixed by wch/extrafont#38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file R/src/library/grDevices/src in the R project has a list of all acceptable keywords. The list does not contain "Characters", which does appear in afm files generated by Rttf3pt1. The result is an ugly warning every time a font is used. This change suppresses the addition of this keyword.