Ansible 2.8 compatibility #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 2, 2020 10:26
…estart inside the wcm_io_devops.conga_bundle_files role now
…e instance when copy task in conga_files has changed.
…be handlers" since handlers are not working in 2.8+ as needed.
…_devops.conga_files or wcm_io_devops.conga_bundle_files have changed
added 5 commits
December 11, 2020 12:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the role compatible with Ansible 2.8+.
The main issue with Ansible 2.8+ is that the implemented restart mechanisms in the roles
have stopped working.
Basically this PR changes the restart logic of the role and moves it from handlers to explicit restarts.
This PR depends on the following PRs from the dependend roles:
We are now using the result facts from wcm_io_devops.conga_files, wcm_io_devops.conga_bundle_files and wcm_io_devops.conga_aem_packages to determine if a restart is required or not after the roles were applied.
In order to merge this PR we need to merge the dependend PRs before and release the roles to Ansible Galaxy.