feat: remove expect dependency #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #14 |
wdhongtw
force-pushed
the
feat-remove-expect-dependency
branch
from
d483916
to
34868e2
Compare
wdhongtw
force-pushed
the
feat-remove-expect-dependency
branch
from
34868e2
to
d7da5ff
Compare
deeprobin
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
LGTM
I made a few comments. You can take a look at whether you take over all or only a few.
Mainly style changes.
But I would ask you if UTF-8 is really necessary everywhere. UTF-8 is of course the new standard but if the Assuan protocol uses e.g. only ASCII it makes more sense to use it because it is more performant to parse.
wdhongtw
force-pushed
the
feat-remove-expect-dependency
branch
from
f1f8bcb
to
4c5d9ad
Compare
- Add new library to implement GPG Assuan protocol. - Rework unlocking logic by signing through Assuan protocol.
wdhongtw
force-pushed
the
feat-remove-expect-dependency
branch
from
7b20d9a
to
ab9120a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related document