Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix middleware ordering for nested wrap-routes #157

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

Deraen
Copy link
Contributor

@Deraen Deraen commented Jan 30, 2017

Hi,

Currently there are no test that tests in what order nested route middlewares are applied.

This PR adds a test to check that the outermost route middlewares are applied first, same as regular middlewares, and changes route-middleware to fix this test.

@weavejester
Copy link
Owner

weavejester commented Jan 31, 2017

Thanks for the fix! Can you change the commit message to:

Fix middleware ordering for nested wrap-routes

@Deraen
Copy link
Contributor Author

Deraen commented Jan 31, 2017

Done

@weavejester weavejester changed the title Test route-middleware ordering with nested wrap-routes Fix middleware ordering for nested wrap-routes Jan 31, 2017
@weavejester weavejester merged commit 3bdbc2f into weavejester:master Jan 31, 2017
@weavejester
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants