-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudwatch Logs Insights Target #423
Add Cloudwatch Logs Insights Target #423
Conversation
015f728
to
8a96565
Compare
8a96565
to
61255e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just spotted that in the previous PR you removed the s from wrapLogMessages
to wrapLogMessage
, was this intentional?
Also if you have any example dashboards use the cloudwatch target that you would like to contribute to the repo to help people starting with the library, then please feel free to raise a separate PR
https://github.com/weaveworks/grafanalib/tree/main/grafanalib/tests/examples
470597f
to
7ebf4c5
Compare
This is how the dashboard is represented in the JSON when it is exported from Grafana:
|
OK, that make sense. Line 3103 in 94175f4
Thanks |
@JamesGibo I have reverted to |
@JamesGibo May be worth checking out? ;) |
Interesting, thanks for sharing, will take a look. |
Thanks once PR #424 is merged, this one will need to be updated to use the correct name |
7ebf4c5
to
e18fb6e
Compare
What does this do?
Introduces the Cloudwatch Logs Insights Target
Why is it a good idea?
We can visualise both Cloudwatch metrics and logs within the same dashboard
Context
Questions