Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing overrides to timeseries visualization #425

Conversation

Puneeth-n
Copy link
Contributor

What does this do?

This PR adds the missing attributes to timeseries visualization

Why is it a good idea?

This allows the grafanalib users to override series in Timeseries visualization

Context

Screenshot 2021-11-01 at 9 41 15 AM

Questions

@Puneeth-n Puneeth-n force-pushed the fix/add-missing-overrides-to-timeseries-visualization branch from 87ea28d to 15ad39c Compare November 1, 2021 08:44
Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me

@JamesGibo JamesGibo merged commit 5e1f0ec into weaveworks:main Nov 1, 2021
@Puneeth-n Puneeth-n deleted the fix/add-missing-overrides-to-timeseries-visualization branch November 1, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants