Add ePict Plugin #512
Merged
Add ePict Plugin #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGibo
requested changes
Sep 9, 2022
There was a problem hiding this comment.
Thanks for the PR, the code to add support for ePict plugin looks good, but have not actually tested using it.
The changes you have made to the examples and docs, please could you put in a separate PR as I am not sure they will work.
Also you have deleted the following files, please could you re add them?:
- grafanalib/tests/examples/table-example-dashboard.py
- grafanalib/tests/examples/upload_grafana_dashboard.sh
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Make the ePict plugin available.
Why is it a good idea?
More functionality