Add support for Elasticsearch Rate Metric Aggregator #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGibo
reviewed
May 18, 2023
JamesGibo
requested changes
May 18, 2023
There was a problem hiding this comment.
Thanks for the PR, it looks good, just a minor import missing.
Add the following to fix the test error
from attr.validators import in_
Please could you also add a note to the release notes?
I have also added an issue to test the Elasticsearch file as realised it is missing a test file.
#589
Co-authored-by: JamesGibo <22477854+JamesGibo@users.noreply.github.com>
|
haha, you were too quick. I just pushed the changelog change, but it was missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This adds support for the "Rate Aggregation" as a metric in an Elasticsearch query.
Why is it a good idea?
This is supported in Grafana, and my team needed it for something. I figure others might too.
Context
Questions