This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 227
Documentation updates and clarifications for the New Storage implementation #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelho
added
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/documentation
Categorizes issue or PR as related to documentation.
do-not-merge/wip
The PR is still work in progress
labels
Jul 29, 2019
luxas
reviewed
Jul 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
5 tasks
Now it's ready, all comments of #234 are now addressed and the code is rebased on top of master. |
Removed the graph update. |
luxas
approved these changes
Jul 29, 2019
luxas
removed
the
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
label
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends @luxas's reviews in #234 to provide additional fixes and documentation clarifications. See the aforementioned PR for details.