Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Activate v1alpha2 in the scheme #259

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Activate v1alpha2 in the scheme #259

merged 1 commit into from
Jul 31, 2019

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Jul 31, 2019

@twelho noted that this also needs to be done to activate the new types (ref: #250)

@luxas luxas added this to the v0.5.0 milestone Jul 31, 2019
@luxas
Copy link
Contributor Author

luxas commented Jul 31, 2019

To get an idea of the size of this: it increases the binary size with 0.2MB (by including v1alpha2 in the builds)

twelho
twelho approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@twelho twelho merged commit bc92e70 into weaveworks:master Jul 31, 2019
@luxas luxas added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho twelho approved these changes

Assignees

@twelho twelho

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luxas @twelho