-
Notifications
You must be signed in to change notification settings - Fork 227
Conversation
docs/declarative-config.md
Outdated
cpus: 2 | ||
diskSize: 3GB | ||
memory: 800MB | ||
``` | ||
|
||
This API object specifies a need for 2 vCPUs, 800MB of RAM and 3GB of disk. | ||
This API object specifies a need for 2 vCPUs, 800 MB of RAM and 3 GB of disks space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: disk space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks
|-------|------------------|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| Intel | x86_64 | Complete | Requires <a href="https://en.wikipedia.org/wiki/X86_virtualization#Intel_virtualization_(VT-x)">VT-x</a>, most non-Atom 64-bit Intel CPUs since Pentium 4 should be supported | | ||
| AMD | x86_64 | Alpha | Requires [AMD-V](https://en.wikipedia.org/wiki/X86_virtualization#AMD_virtualization_.28AMD-V.29), most AMD CPUs since the Athlon 64 "Orleans" should be supported | | ||
| ARM | AArch64 (64-bit) | Alpha | Requires GICv3, see [here](https://github.com/firecracker-microvm/firecracker/issues/1196) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for pointing this out 👍
<component name="Go" enabled="true" /> | ||
<component name="NewModuleRootManager" inherit-compiler-output="true"> | ||
<exclude-output /> | ||
<content url="file://$MODULE_DIR$" /> | ||
<orderEntry type="inheritedJdk" /> | ||
<orderEntry type="sourceFolder" forTests="false" /> | ||
<orderEntry type="library" name="Python 3.7 interpreter library" level="application" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
can we just drop this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to drop IDE-specific configuration, I'll do it in a separate PR
This should be all of the docs, removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for this PR!
LGTM 👍
This PR contains a collection of documentation updates/enhancements for v0.5.0.
Fixes #312.
cc @luxas