Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add shell autocompletion for ignited #363

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

silenceshell
Copy link
Contributor

Add completion for ignited.

root@pve:~# ignited # press tab twice here
completion  daemon      gitops      version

Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @silenceshell, this looks good 😄
I think you need to run a make tidy locally to autogenerate the CLI documentation

cc @twelho who knows this code better than me

@silenceshell
Copy link
Contributor Author

@luxas make tidy done, please have a look

Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@twelho twelho merged commit 9608fc1 into weaveworks:master Aug 27, 2019
@silenceshell silenceshell deleted the ignited-completion branch August 27, 2019 11:20
@luxas luxas changed the title add completion for ignited Add shall autocompletion for ignited Aug 30, 2019
@luxas luxas changed the title Add shall autocompletion for ignited Add shell autocompletion for ignited Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants