Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Implement runtime selection, only load necessary providers #366

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Implement runtime selection, only load necessary providers #366

merged 2 commits into from
Aug 27, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 27, 2019

  • Adds a --runtime flag to select which runtime to use similar to the --network-plugin flag.
  • Providers are loaded on-demand instead of always initializing everything.
  • Added a check to fail if the docker-network plugin is used with a runtime other than docker.
  • Added a warning for the containerd runtime being unstable/incomplete.

@twelho twelho added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/enhancement Categorizes issue or PR as related to improving an existing feature. labels Aug 27, 2019
@twelho twelho added this to the v0.6.0 milestone Aug 27, 2019
@twelho twelho requested a review from luxas August 27, 2019 14:49
luxas
luxas approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

LGTM 👍

@luxas luxas self-assigned this Aug 27, 2019
@luxas luxas merged commit f042d9a into weaveworks:master Aug 27, 2019
@twelho twelho deleted the runtime-selection branch August 27, 2019 15:49
@luxas luxas mentioned this pull request Aug 30, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@twelho @luxas