Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

containerd backend improvements #368

Merged
merged 7 commits into from
Aug 30, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 27, 2019

Aims to make the containerd backend viable for basic operations, such as starting, stopping, removing and attaching to VMs. I'll add more commits to this PR as I progress, the intermediate states might not compile/are not clean, this PR collects them together before merging.

cc @luxas

@twelho twelho added kind/feature Categorizes issue or PR as related to a new feature. kind/enhancement Categorizes issue or PR as related to improving an existing feature. do-not-merge/wip The PR is still work in progress labels Aug 27, 2019
@twelho twelho added this to the v0.6.0 milestone Aug 27, 2019
@twelho twelho self-assigned this Aug 27, 2019
@twelho twelho changed the title [WIP] containerd backend improvements containerd backend improvements Aug 30, 2019
@twelho twelho removed the do-not-merge/wip The PR is still work in progress label Aug 30, 2019
@twelho
Copy link
Contributor Author

twelho commented Aug 30, 2019

The containerd backend is now fully featured and should match the functionality of the Docker backend. ContainerLogs requires asynchronous I/O, for now it relies on a time.Sleep to work (needs to be improved in the future).

@twelho
Copy link
Contributor Author

twelho commented Aug 30, 2019

CI is green, merging 👍

@twelho twelho merged commit 3dee0c7 into weaveworks:master Aug 30, 2019
@twelho twelho deleted the containerd-improvements branch August 30, 2019 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant