Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Move VM network removal to logically correct place #373

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Move VM network removal to logically correct place #373

merged 1 commit into from
Aug 30, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 30, 2019

Enables cni to remove VM networks correctly.

cc @luxas

@twelho twelho added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 30, 2019
@twelho twelho added this to the v0.6.0 milestone Aug 30, 2019
luxas
luxas approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@luxas luxas merged commit 0faa61a into weaveworks:master Aug 30, 2019
@twelho twelho deleted the fix-network-removal branch August 29, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@twelho @luxas