Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Set docker back to the default container runtime #408

Closed
wants to merge 2 commits into from
Closed

Set docker back to the default container runtime #408

wants to merge 2 commits into from

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Sep 6, 2019

Per user feedback, we'll keep docker as the default container runtime for a while.

@chanwit
Revert "Make containerd the default runtime and CNI the default netwo…
745983d 
…rk plugin"

This reverts commit f674dad.

Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit
re-generate docs
528244f 
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit chanwit requested a review from twelho as a code owner September 6, 2019 17:01
@chanwit
Copy link
Member Author

chanwit commented Sep 6, 2019 •
edited
Loading 

$ sudo bin/ignite version

Ignite version: version.Info{Major:"0", Minor:"6+", GitVersion:"v0.6.0-13+528244f9dcccfe-dirty", GitCommit:"528244f9dcccfe527fe96a74c6a9ba8e7e336e01", GitTreeState:"dirty", BuildDate:"2019-09-06T16:58:18Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Firecracker version: v0.17.0
Runtime: docker

@chanwit
Copy link
Member Author

chanwit commented Sep 6, 2019

all green /cc @stealthybox PTAL

@dlespiau dlespiau mentioned this pull request Sep 6, 2019
Closed
@stealthybox
Copy link
Contributor

stealthybox commented Sep 7, 2019 •
edited
Loading

Fixes #390
We'll probably close this patch in favor of #411
The bug with ignite vm stop --runtime docker since docker-bridge is no longer the default would still need to be fixed (#393)

@chanwit
Copy link
Member Author

chanwit commented Sep 15, 2019

#411 merged so this one could be closed.

@chanwit chanwit closed this Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho Awaiting requested review from twelho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chanwit @stealthybox