Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

use ssh discover technique to check if SSH service is really run… #469

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Oct 6, 2019

This PR improves the SSH wait mechanism by trying to authen the SSH server of a VM.
If the SSH returns "unable to authen" then it seems to be really up and running.

Thank you @lucidprogrammer who found this bug on his baremetal box.
I also found this bug too when running Ignite on a very machine.

@stealthybox this seems to be an urgent fix needed by tmr event.
and we also need it for v0.5.5.

@chanwit chanwit requested a review from twelho as a code owner October 6, 2019 19:55
@chanwit chanwit removed the request for review from twelho October 7, 2019 06:24
@chanwit chanwit added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2019
@stealthybox
Copy link
Contributor

This is unfortunately even slower than before.
It definitely is reasonable to see how this could address some SSH/ignite exec race conditions:

time sudo ignite-v0.6.1 run weaveworks/ignite-ubuntu --ssh
INFO[0000] Created VM with ID "352579ed0c948d0e" and name "broken-dew" 
INFO[0001] Networking is handled by "cni"               
INFO[0001] Started Firecracker VM "352579ed0c948d0e" in a container with ID "ignite-352579ed0c948d0e" 
sudo ignite-v0.6.1 run weaveworks/ignite-ubuntu --ssh  0.19s user 0.14s system 9% cpu 3.496 total

time sudo ./bin/ignite run weaveworks/ignite-ubuntu --ssh
INFO[0000] Created VM with ID "67548738f4251506" and name "blue-snowflake" 
INFO[0001] Networking is handled by "cni"               
INFO[0001] Started Firecracker VM "67548738f4251506" in a container with ID "ignite-67548738f4251506" 
sudo ./bin/ignite run weaveworks/ignite-ubuntu --ssh  0.21s user 0.15s system 6% cpu 5.751 total

@stealthybox stealthybox changed the title use ssh discover technique to check if SSH service is really running use ssh discover technique to check if SSH service is really run… Oct 7, 2019
@stealthybox stealthybox merged commit d7cf3f6 into weaveworks:master Oct 7, 2019
stealthybox added a commit that referenced this pull request Oct 8, 2019
…ally run… (#469)

use ssh discover technique to check if SSH service is really running
stealthybox added a commit that referenced this pull request Oct 8, 2019
use ssh discover technique to check if SSH service is really running
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants