This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add --require-name to create and run commands #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --require-name flag to create and run commands to fail when a VM name is not passed. This can be used along with config file to avoid generating different resource from the same config file due to generated name and UID. Adds tests for the change.
Adds require-name check in VM config file. Adds test TestNewCreateOptions to test the failure cases when --require-name is set and no name is provided only.
darkowlzz
force-pushed
the
create-run-require-name
branch
from
95a56a6
to
8916a08
Compare
darkowlzz
commented
Mar 16, 2020
| RequireName: true, | ||
| }, | ||
| err: true, | ||
| }, |
There was a problem hiding this comment.
These cases cover only the failure cases of NewCreateOptions. Success case would lead to actual image imports and would require setting up a back-end storage as well. These tests are enough for checking the --require-name flag.
|
Added require-name check for VM config file as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--require-nameflag to create and run commands to fail when a VMname is not passed. This can be used along with config file to avoid
generating different resource from the same config file due to generated
name and UID.
Adds tests to verify the change.
Follow up of #525