Allow multiple calls to ensureRecalculated() to wait on the same calculation #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
approved these changes
Aug 27, 2019
…ulation If another call is already waiting, wait on the same chan. This is an improvement on the previous behaviour that only allowed one ensureRecalculated() to proceed per calculate(), in the presence of many recalculate() requests. It is now possible for a later call to overtake the first. Previously it was possible for a later call to overtake an earlier call except for the first.
bboreham
force-pushed
the
coalesce-ensure-recalculated
branch
from
c309fcb
to
4e69d97
Compare
|
LGTM. Have scale tested this patch along with #111 on 200 node cluster with significant reduction in CPU usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If another call is already waiting, wait on the same
chanso we coalesce waiters.This is an improvement on the previous behaviour that only allowed one
ensureRecalculated()to proceed percalculate(), in the presence of manyrecalculate()requests.It is now possible for a later call to overtake the first. Previously it was possible for a later call to overtake an earlier call except for the first.