Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elide probe tokens from urls in logs #2365

Closed
2opremio opened this issue Mar 21, 2017 · 1 comment
Closed

Elide probe tokens from urls in logs #2365

2opremio opened this issue Mar 21, 2017 · 1 comment
Assignees
@rndstr
Labels
bug Broken end user or developer functionality; not working as the developers intended it

Comments

@2opremio
Copy link
Contributor

We elided the value of --service-token in #1782 but we started leaking tokens again after #1901

See the manually-included <elided> tags in #2336 (comment)
@2opremio 2opremio added the bug Broken end user or developer functionality; not working as the developers intended it label Mar 21, 2017
@rndstr rndstr self-assigned this Jun 5, 2017
@rndstr
Copy link
Contributor

rndstr commented Jun 6, 2017

Do you think any of the flags could contain urls with tokens/passwords as well?

rndstr added a commit that referenced this issue Jun 6, 2017
@rndstr
Elide url passwords in cli arguments
6c1d7f2 
Fixes #2365
@rndstr rndstr mentioned this issue Jun 6, 2017
Merged
rndstr added a commit that referenced this issue Jun 7, 2017
@rndstr
Elide url passwords in cli arguments (#2568)
2e4f4a3 
Closes #2365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rndstr rndstr

Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rndstr @2opremio